"Aaron Schulz" posted a comment on MediaWiki.r110039. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110039#c30043
Commit summary for MediaWiki.r110039: * implemented overwrite param * implemented missing methods (isPathUsableInternal, doSecureInternal) * additional checks for invalid paths * fixed bug in getFileList that lead to thumbnails not being regenerated * all FileBackendTests pass Aaron Schulz's comment: I see $this->storageClient->blobExists() checks were they are only needed if there is no 'overwrite' param. They should only be called in that case. Also, I'd kill doFileExists() since it won't be called. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
