"Tim Starling" posted a comment on MediaWiki.r108353. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108353#c30046
Commit summary for MediaWiki.r108353: In FileBackend: * Added getFileSize()/getFileStat() functions. Refactored some functions to use the stat function for better reuse and caching/consistency. * Refactored streamFile() to allow for subclasses to avoid local file copying with less duplication. Also make last-modified check actually work since we always get the timestamp of the original file. * Renamed 'ignoreErrors' parameter to 'force'. In FileBackendMultiWrite: * Simplified how read ops are done (use 'master' backend for consistency). * Added consistency check to doOperationsInternal() to check if the files are synced. * Various fixes after testing. In StreamFile: * Split out prepareForStream() function from stream() in StreamFile for code reuse. In FileBackendTest: * Properly cover FileBackendMultiWrite in tests. * Various test improvements. Tim Starling's comment: The consistency check is concerning because it requires the file timestamps for a given file to match in all backends. During initial setup, this might be difficult to achieve, depending on what clients and script are available for populating the object store with data. Perhaps the backend could have a "consistency check mode" option which would allow the user to choose between: * No consistency check * Check size (good default?) * Check timestamp * Both? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
