"Catrope" posted a comment on MediaWiki.r109368. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109368#c30052
Commit summary for MediaWiki.r109368: Development of feedback page style sheet. Catrope's comment: <pre> + background-image:url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAAjCAIAAADaE/fjAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAyRpVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADw/eHBhY2tldCBiZWdpbj0i77u/IiBpZD0iVzVNME1wQ2VoaUh6cmVTek5UY3prYzlkIj8+IDx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6bWV0YS8iIHg6eG1wdGs9IkFkb2JlIFhNUCBDb3JlIDUuMC1jMDYxIDY0LjE0MDk0OSwgMjAxMC8xMi8wNy0xMDo1NzowMSAgICAgICAgIj4gPHJkZjpSREYgeG1sbnM6cmRmPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4gPHJkZjpEZXNjcmlwdGlvbiByZGY6YWJvdXQ9IiIgeG1sbnM6eG1wPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvIiB4bWxuczp4bXBNTT0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL21tLyIgeG1sbnM6c3RSZWY9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9zVHlwZS9SZXNvdXJjZVJlZiMiIHhtcDpDcmVhdG9yVG9vbD0iQWRvYmUgUGhvdG9zaG9wIENTNS4xIE1hY2ludG9zaCIgeG1wTU06SW5zdGFuY2VJRD0ieG1wLmlpZDo4QzkwMjE1MjE0RTExMUUxQTkyM0IxNzE3N0RFODgwNiIgeG1wTU06RG9jdW1lbnRJRD0ieG1wLmRpZDo4MTMwRTQxMjE0RTIxMUUxQTkyM0IxNzE3N0RFODgwNiI+IDx4bXBNTTpEZXJpdmVkRnJvbSBzdFJlZjppbnN0YW5jZUlEPSJ4bXAuaWlkOjhDOTAyMTUwMTRFMTExRTFBOTIzQjE3MTc3REU4ODA2IiBzdFJlZjpkb2N1bWVudElEPSJ4bXAuZGlkOjhDOTAyMTUxMTRFMTExRTFBOTIzQjE3MTc3REU4ODA2Ii8+IDwvcmRmOkRlc2NyaXB0aW9uPiA8L3JkZjpSREY+IDwveDp4bXBtZXRhPiA8P3hwYWNrZXQgZW5kPSJyIj8+OdQuLwAAAEFJREFUeNpcjcENACAIAysrOZNLuputoWo0vi5HKaC2HpBCUBSTdoieOROXPyzmzaCxfTy7XzfvMbm6SVDnzxRgACWnTTX5Rk3FAAAAAElFTkSuQmCC) !important; </pre> WTF? Don't embed data URLs like that, save the image as an image file and use /* @embed */ , that way ResourceLoader will automatically do the data URL processing for you. Per John's comment, you should also add /* @embed */ for the other image file references you're adding. <pre> + box-shadow:#999999 -2px 2px 1px; + background-attachment:scroll !important; + background-clip:initial !important; </pre> Indentation is messed up. The i18n change was reverted later, so that's fine. Marking fixme for the data URL and @embed issues, the rest is OK. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
