"^demon" changed the status of MediaWiki.r109698 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109698#c30066
Old Status: new > New Status: fixme Commit summary for MediaWiki.r109698: [Unit testing] Add unit tests for Xml::namespaceSelector * Making Language::namespaceNames explicitly public. It already was but since is being used as such outside the class ^demon's comment: Do not explicitly make this public. I know there's no functional difference but there's a practical one. If you need a member var outside of a class you should write accessors. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
