"^demon" posted a comment on MediaWiki.r109698. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109698#c30071
Commit summary for MediaWiki.r109698: [Unit testing] Add unit tests for Xml::namespaceSelector * Making Language::namespaceNames explicitly public. It already was but since is being used as such outside the class ^demon's comment: In fact, before this revision not a single usage of $namespaceNames was outside of this class (core or extensions). That's even more reason to make it protected and slap accessors on it rather than making it public. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
