"Aaron Schulz" posted a comment on MediaWiki.r100165.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100165#c30079

Commit summary for MediaWiki.r100165:

Adds API Module by cryptocoryne

Bug 31723

Aaron Schulz's comment:

<pre>
-       protected function getIpConds( $db, $ip, $xfor = false ) {
+       public static function getIpConds( $db, $ip, $xfor = false ) {
</pre>

I'd rather these be moved to their own static class file rather than have the 
API borrow some special page functions.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to