"Gregchiasson" posted a comment on MediaWiki.r110086.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110086#c30107
Commit summary for MediaWiki.r110086:
AFT5 - SQL statements to rebuild the rollup tables using only bucket 1, and a
fix to prevent loading errors if a record with no timestamp comes up (which
should be impossible anyway, but has happened on dev, and should be handled
either way, instead of breaking the page).
Gregchiasson's comment:
It stops $wgLang->timeanddate() from throwing an error when it gets an invalid
timestamp (see below), which was the original problem. $date's still undefined
though, which I guess means I don't have php errors turned up loud enough on my
dev environment, because I missed that.
#0 /home/reha/svn/mediawiki/includes/GlobalFunctions.php(1314):
MessageCache->get(NULL, true, Object(Language)) #1
/home/reha/svn/mediawiki/includes/GlobalFunctions.php(1439): wfMsgGetKey(NULL,
true, Object(Language), false) #2
/home/reha/svn/mediawiki/languages/Language.php(699): wfMsgExt(NULL, Array) #3
/home/reha/svn/mediawiki/languages/Language.php(721):
Language->getMessageFromDB(NULL) #4
/home/reha/svn/mediawiki/languages/Language.php(979):
Language->getMonthName(false) #5
/home/reha/svn/mediawiki/languages/Language.php(1848):
Language->sprintfDate('H:i, j F Y', false) #6
/home/reha/svn/mediawiki/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php(306):
Language->timeanddate('2011-12-02 15:') #7
/home/reha/svn/mediawiki/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php(47):
ApiViewFeedbackArticleFeedbackv5->renderFeedback(Array) #8
/home/reha/svn/mediawiki/includes/api/ApiQuery.php(266):
ApiViewFeedbackArticleFeedbackv5->execute() #9
/home/reha/svn/mediawiki/includes/api/ApiMain.php(705): ApiQuery->execute()
#10 /home/reha/svn/mediawiki/includes/api/ApiMain.php(360):
ApiMain->executeAction() #11
/home/reha/svn/mediawiki/includes/api/ApiMain.php(344):
ApiMain->executeActionWithErrorHandling() #12
/home/reha/svn/mediawiki/api.php(117): ApiMain->execute() #13 {main}
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
