"Krinkle" posted a comment on MediaWiki.r109786.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109786#c30147
Commit summary for MediaWiki.r109786:
[ApiSandbox] bug fix
* Looks like API is returning HTML here, got a couple of <br> and <li>'s
* Wrapping parens only if there is a link, got a couple of loose () before
Krinkle's comment:
</code><code></code>
No, there is a significant different. A bugfix even.
If <tt>linkHtml</tt> is not populated (e.g when <code>if ( this.info.helpurls
&& this.info.helpurls[0] ) {</code> evaluates to false), then calling
<code>mw.msg( 'parentheses', linkHtml )</code> would add a bogus empty pair of
parentheses ("()") to the end of the textnode. The movement is a bugfix in this
commit.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
