"Aaron Schulz" posted a comment on MediaWiki.r109455.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109455#c30169

Commit summary for MediaWiki.r109455:

Adding Email blacklisting to the SpamBlacklist extension

This relies on r109111

Aaron Schulz's comment:

<pre>public function checkUser( User $user )</pre>

The docs are confusing. It seems like it's checking if they ARE blacklisted, 
when it's return value is the opposite. The function should be renamed and the 
docs clearer.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to