"Santhosh.thottingal" posted a comment on MediaWiki.r110068.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110068#c30209
Commit summary for MediaWiki.r110068:
AFT5:
- Fix some translation issues: remove a few unused messages (take them out of
hooks.php as well), add missing qqq doucmentation for others.
- Tweak text for up/down voting message, per requirements
- Add active class in CSS/JS for clicked 'is this helpful' yes/no buttons, per
requirements.
- Don't display sort direction arrow on page load, per requirements.
- Make permalink filter take affect immediately, instead of just changing URL
and requiring a reload.
- Comment out AFT5 special page display (was uncommented in dev, but needs to
be commented out for committing - fixes a bug in r108881).
- Escape $continue value before using it in a query. Fixes the other bug in
r108881.
- Use relative timestamps ('2 hours 19 minutes ago') for feedback posts less
than 48 hours old (Taken largely from the way Moodbar does it).
- Remove the old commented-out permalinks, since the timestamp is the new link
.
- Only show the 'X edits since' links (goes to diff page) if there have been
edits since.
- Stop double-escaping feedbackHead (r109254), and add gender back into the me
ssage.
- Replace 'all' filter with 'visible' - there is no 'all' filter anymore. Remo
ve 'needs oversight' filter, as the 'request oversight' functionality is off t
he table for initial release. Will remove the links to it as well, but this co
mmit only takes out the filter.
Santhosh.thottingal's comment:
To make the code review easier it would be better if you can do split the
commits across bugs, functional changes, etc. A single commit with multiple
functional changes, message changes, UI changes, code clean up, bug fixes etc
are difficult to review.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
