"Hashar" changed the status of MediaWiki.r109195 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109195#c30237
Old Status: new
> New Status: ok
Commit summary for MediaWiki.r109195:
[Actions] Move the remaining actions out of MediaWiki::performAction into
single action classes (finally).
- [Actions] -
* I am aware that eventually these classes should be more than just a few lines
re-directing control to WikiPage, but I'm keeping these commits as
uncontroversial as possible due to feature freeze. Refactor could be done later.
* Contributes to solution of bug 27930 - Ablity to get current action (The
Right Way)
* Final goal: Get the current action without needing access to Wiki.php
internals (i.e. with Action::factory in one hand and an instance of
IContextSource in the other)
* Required for proper fix of r108342/108343 (currently marked FIXME)
Hashar's comment:
Now we just need a nice UnknownAction action class to get ride of the remaining
code:
if ( wfRunHooks( 'UnknownAction', array( $act, $article ) ) ) {
$this->performedAction = 'nosuchaction';
$output->showErrorPage( 'nosuchaction', 'nosuchactiontext' );
}
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
