"Awjrichards" changed the status of Wikimedia.r1240 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1240#c30250
Old Status: new
> New Status: fixme
Commit summary for Wikimedia.r1240:
Working on the file handling aspects of the gc_wr1 drush command. Still needs
more work. All the code is there, but it still needs to be functionalized as
per my inline notes.
Awjrichards's comment:
<pre>
//This simple sort will work on the GC file naming convention until the
year
//2020, when January will come up before anything else in the previous
year.
//By that time, they will hopefully have changed their dumb 8-char
filename
//standard anyway.
</pre>
lolz.
<pre>
$newfile = explode( '/', $file );
$just_name = $newfile[ count($newfile)-1 ];
$newfile[ count($newfile)-1 ] = $subdir;
$newfile[] = $just_name;
$newfile = implode( '/', $newfile );
</pre>
This is clever, but perhaps unnecessary. You might consider using pathinfo()
(http://us.php.net/manual/en/function.pathinfo.php) for
simplicity/clarity/shareability/etc.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
