"Krinkle" changed the status of MediaWiki.r110340 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110340#c30253

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r110340:

Fixes bug 34036 - [regression] mw.loader.load doesn't works as importScriptURI 
for some kinds of URLs
Patch from Helder.wiki

Krinkle's comment:

As documented, mw.loader.load takes one or more module names or a full url. 
Relative paths are not accepted.

Adding an exception in the protocol regex for one particular file in the root 
(index.php) makes no sense. What about the API, or uploads, or files in 
extension paths ? No need to add all these.

importScriptURI is not exactly the same as mw.loader.load. If and when a user 
decides to change one for the other, the url should be make complete. So in the 
case of calls to index.php, wgServer needs to be prefixed.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to