"Aaron Schulz" posted a comment on MediaWiki.r80240.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80240#c30255
Commit summary for MediaWiki.r80240:
Fix bug 14267 by adding support for a MediaWiki:Mainpage-nstab.
Additionally, *cough* *cough*:
* Add a Title::isMainPage helper for the fairly common $title->equals(
Title::newMainPage() ); test.
* Update wfMessageFallback to also accept an array of message keys instead of
requiring them listed as arguments to the function.
* Move the bulk of wfMessageFallback code into Message.php instead of leaving
it in GlobalFunctions.php
* Change the wfMessageFallback implementation so that the Message class handles
the fallbacks themselves eliminating any side effects caused by the fact that
wfEmptyMsg always used usedb=false, language=userlang when one might actually
use a different language or usedb setting in the message object that actually
returned the text (this may be considered a wfEmptyMsg regression in 1.18).
* Make blank "" message contents fallback like nonexistant messages do.
* Re use the new tabAction array handling used to support mainpage-nstab in the
talk and view tabs instead of making wfEmptyMsg calls directly in SkinTemplate.
Aaron Schulz's comment:
Backtrace:
#0 D:\www\MW_clone\includes\Message.php(580): wfDebugDieBacktrace()
#1 D:\www\MW_clone\includes\Message.php(557): Message->fetchMessage()
#2 D:\www\MW_clone\includes\Message.php(370): Message->getMessageText()
#3 D:\www\MW_clone\includes\Message.php(431): Message->toString()
#4 D:\www\MW_clone\includes\OutputPage.php(3433): Message->plain()
#5 D:\www\MW_clone\includes\specials\SpecialMovepage.php(211):
OutputPage->addWikiMsgArray(Array, 'imagenocrossnam...')
#6 D:\www\MW_clone\includes\specials\SpecialMovepage.php(450):
MovePageForm->showForm(Array)
#7 D:\www\MW_clone\includes\specials\SpecialMovepage.php(97):
MovePageForm->doSubmit()
#8 D:\www\MW_clone\includes\SpecialPageFactory.php(476):
MovePageForm->execute(NULL)
#9 D:\www\MW_clone\includes\Wiki.php(263):
SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
#10 D:\www\MW_clone\includes\Wiki.php(593): MediaWiki->performRequest()
#11 D:\www\MW_clone\includes\Wiki.php(503): MediaWiki->main()
#12 D:\www\MW_clone\index.php(58): MediaWiki->run()
#13 {main}
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
