"Catrope" changed the status of MediaWiki.r109565 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109565#c30263
Old Status: new > New Status: fixme Commit summary for MediaWiki.r109565: AFT5 feedback page - allow sorting by helpfulness, and add unhelpful flag, per mockups. Streamline some of the JS, and improve a couple of translation lines. Catrope's comment: <pre> + 'articlefeedbackv5-special-sort-helpful' => 'Most Helpful', </pre> Don't Capitalize Everything <pre> + ), wfMessage( 'articlefeedbackv5-form-helpful-label', ( $record[0]->af_helpful_count + $record[0]->af_unhelpful_count ) ) ) [...] + ), wfMessage( 'articlefeedbackv5-form-helpful-votes', ( $record[0]->af_helpful_count + $record[0]->af_unhelpful_count ), $record[0]->af_helpful_count, $record[0]->af_unhelpful_count ) ) </pre> Don't use implicit stringification of Message objects, explicitly call ->text() (or whatever you need here). You will also need to run numbers through $wgLang->formatNum() before passing them in as message parameters. Benny is right about the unnecessary validation and the concurrency issue. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
