"Catrope" changed the status of MediaWiki.r109441 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109441#c30264

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r109441:

AFT5 feedback page: enable permalinks and 'edits since post' functionality. Fix 
a couple of issues with the translation.

Catrope's comment:

<pre>
+                               'af_helpful_count', 'af_delete_count', '(SELECT 
COUNT(*) FROM revision WHERE rev_id > af_revision_id AND rev_page = '.( integer 
) $pageId.') AS age'
</pre>
Subqueries with COUNT(*) make me sad. Is this really a required feature? If so, 
I'd like to try to convince Fabrice to drop it.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to