"Catrope" posted a comment on MediaWiki.r109565. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109565#c30267
Commit summary for MediaWiki.r109565: AFT5 feedback page - allow sorting by helpfulness, and add unhelpful flag, per mockups. Streamline some of the JS, and improve a couple of translation lines. Catrope's comment: <pre> + $order = 'net_helpfulness DESC'; + $continueSql = 'net_helpfulness <'; </pre> You can't order by a computed field. That's unindexed and will melt our database servers. If you really need to order by net helpfulness, put in a field for net helpfulness, index it, and order by that. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
