"Catrope" changed the status of MediaWiki.r109631 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109631#c30268
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r109631:
AFT5 - sorting doesnt work right (feedbackpage) but the designers want the
latest HTML, so here it is.
Catrope's comment:
<pre>
+ id = $.articleFeedbackv5special.stripID( this,
'articleFeedbackv5-special-sort-' );
+ oldId = $.articleFeedbackv5special.sort;
</pre>
This makes the <code>id</code> and <code>oldId</code> variables global, use
<code>'''var''' id = $.foobar();</code>
<pre>
+ id = $.articleFeedbackv5special.sort;
+ dir = $.articleFeedbackv5special.sortDirection;
</pre>
Same.
<pre>
+console.log('id is ' + id + ', old id is ' + oldId);
</pre>
Debugging code, removed in r109645
<pre>
$order;
+ $continue;
</pre>
What are these lines here for? You don't have to declare variables before using
them in PHP.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
