"Catrope" changed the status of MediaWiki.r109833 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109833#c30270
Old Status: new > New Status: fixme Commit summary for MediaWiki.r109833: AFT5 feedback page - adding HTML classes for the designers, and making the username/IP address links work. Catrope's comment: <pre> + $name = htmlspecialchars( $record[0]->user_name ); + $link = $record[0]->af_user_id ? "User:$name" : "Special:Contributions/$name"; </pre> This will go wrong if $name contains characters that are escaped by htmlspecialchars(). You have to use the unescaped name in the title. Also, you can construct these titles using <code>$title = Title::makeTitleSafe( NS_USER, $name );</code> and <code>$title = SpecialPage::getTitleFor( 'Contributions', $name );</code> respectively. OK otherwise. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
