"Catrope" changed the status of MediaWiki.r109931 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109931#c30274
Old Status: new
> New Status: ok
Commit summary for MediaWiki.r109931:
AFT5 feedbackpage - Fix a fixme in the internationalization file. Change
default filter on feedback list. Properly increment filter rollup counts when
flagging feedback. Do permissions checks properly for hide/delte functionality.
Default filter is now 'whatever you asked for, and also non-hidden and
non-deleted' unless you specifically want deleted/hidden feedback. Disable
rendering of an empty tools section, for normal readers. Restrict AFT5 feedback
page to pages with AFT5 enabled.
Catrope's comment:
<pre>
+ $( '#articleFeedbackv5-sort-arrow-' + id ).attr(
+ 'src', 'images/sort ' + dir + 'ending.png'
);
</pre>
Instead of using img tags, you should put your sort arrow images in CSS as
background images. You can take advantage of data URI embedding that way.
<pre>
+$wgAvailableRights[] = 'aftv5-hide-feedback';
+$wgAvailableRights[] = 'aftv5-delete-feedback';
+$wgAvailableRights[] = 'aftv5-see-deleted-feedback';
+$wgAvailableRights[] = 'aftv5-see-hidden-feedback';
</pre>
Forgot to mention earlier that these should have description messages, see
[[Special:Code/MediaWiki/109582#c30265|r109582 CR]].
<pre>
+ && !$wgUser->isAllowed( 'aftv5-ssee-deleted-feedback'
) )
</pre>
Typo apparently fixed in a later revision.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
