"Catrope" changed the status of MediaWiki.r110012 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110012#c30277
Old Status: new > New Status: fixme Commit summary for MediaWiki.r110012: AFT5 feedback page - add truncation to comments over 500 characters, with expand/collapse Javascript. Followup to r109967 Catrope's comment: <pre> + $rv = Html::openElement( 'blockquote', + array( + 'class' => 'articleFeedbackv5-comment-short', + 'id' => "articleFeedbackv5-comment-short-$feedbackId" + ) ) + . htmlspecialchars( $short ) + . Html::closeElement( 'blockquote' ); </pre> You can use <code>Html::element( 'blockquote', array( attributes ), $short );</code> here, that handles escaping for you. <pre> + ), wfMessage( 'articlefeedbackv5-comment-more' )->escaped() ); </pre> Don't escape the argument to Html::element(), that'll escape it twice. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
