"Catrope" changed the status of MediaWiki.r110182 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110182#c30282
Old Status: new > New Status: ok Commit summary for MediaWiki.r110182: AFT5: - Change hidden and deleted counters to boolean flags. Not sure why I used counters in the first place, if I'm honest. - Check for falsnesss of $record in FlagFeedback API (fixes r110098) - Enable sort by rating, which didn't work right before. In doing so, rewrote the queries in ViewFeedback almost entirely. - Check that flags are above 0 when saving - they're unsigned ints, so negative numbers are bad. Catrope's comment: <pre> - array( 'af_hide_count = af_hide_count + 1' ), + array( 'af_is_hidden = af_is_hidden + 1' ), </pre> If is_hidden is a boolean now, why are you still incrementing it? Don't you mean to just set <code>af_is_hidden = TRUE</code> here? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
