"Catrope" changed the status of MediaWiki.r110193 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110193
Old status: new
> New status: resolved
Commit summary for MediaWiki.r110193:
Hide/show is now a toggle:
- ArticleFeedbackv5.i18n.php:
- Updated "articlefeedbackv5-form-hide" to follow the feature
requirements
- Removed old messages 'articlefeedbackv5-hide-saved' and
'articlefeedbackv5-unhide-saved'
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css:
- Added styles for hidden comments
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js:
- Updated setBinds() so that mark as helpful and flag as abuse
don't
work when the feedback is hidden
- Updated setBinds() to make hide work as a toggle
- New methods markHidden() and unmarkHidden()
- Updated flagFeedback() to mark the feedback hidden/unhidden on
success
- Updated loadFeedback() to mark incoming feedback with the
hidden
class using markHidden()
- api/ApiViewFeedbackArticleFeedbackv5.php:
- Dropped unhide link
- Updated hide link to show the message without a count
- Added the hidden class to hidden feedback
- Also cleaned up some stray spaces
- ArticleFeedbackv5.hooks.php:
- Updated to send 'articlefeedbackv5-form-hide' and
'articlefeedbackv5-form-unhide' to the special js
- Dropped 'articlefeedbackv5-hide-saved',
'articlefeedbackv5-helpful-saved',
'articlefeedbackv5-unhelpful-saved', and
'articlefeedbackv5-unhide-saved' from the special js
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
