"Catrope" changed the status of MediaWiki.r110334 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110334
Old status: new
> New status: ok
Commit summary for MediaWiki.r110334:
Tweaks to the feedback page:
1. Marked-as-deleted state now in use alongside the hidden state; marker
changed from blue background to red with no background
2. When flagged as abuse, the links maintain the count
3. You can un-mark a comment as helpful/unhelpful by clicking the button a
second time
4. Probable fix for the double-marking of hidden comments
- ArticleFeedbackv5.i18n.php:
- New message 'articlefeedbackv5-deleted'
- Updated 'articlefeedbackv5-abuse-saved' to include a count
- ArticleFeedbackv5.hooks.php:
- Updated to send the new message to the special page js
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css:
- Changed styling of hidden/deleted markers
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js:
- Updated setBinds() to reject an up/down vote or an abuse
flagging
when the comment is deleted, and to knock down the yes/no
vote on the
second click
- Updated markHidden() to make sure any previous hidden flag
has been
removed before adding a new one and to put the marker after
the date
rather than after the title
- New methods markDeleted() and unmarkDeleted()
- Updated flagFeedback() to send the abuse count to thr saved
message,
to store the count in the rel attibute of the link, and to
call
markDeleted() or unmarkDeleted() on a successful
delete/undelete
- Updated loadFeedback() to catch deleted comments and mark
them as
such, and to add the abuse count to the saved message
- api/ApiViewFeedbackArticleFeedbackv5.php:
- Added the abuse count as the rel attribute on the flag as
abuse link,
so the js can find it
- Added the top level class
"articleFeedbackv5-feedback-deleted" for
deleted comments
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
