"Tim Starling" changed the status of MediaWiki.r109428 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109428#c30323
Old Status: new > New Status: ok Commit summary for MediaWiki.r109428: In SwiftFileBackend: * r108944: doCleanInternal() should delete empty containers only if the container dir was given. * Made doSecureInternal() set container permissions. Also renamed swiftProxyUser -> swiftAnonUser. * Made doGetFileStat() respect the 'latest' parameter (using r109235). * Fixed connTTL default and renamed it to authTTL. Also added explicit close() call to getConnection(). * Reduced RTTs in doPrepareInternal() by checking getContainer() first (which is process cached). * Killed an RTT in doStoreInternal(), doCreateInternal(), and doCopyInternal() by using create_object(). Also cleaned up logic with regards to the destination CF_Object object fields getting preloaded before write(). * Cleanups to getLocalCopy(); only create the tmp file if get_object() succeeds to short-circuits things. * Made getContainer() limit the container cache size for sanity. * Simplified doDeleteInternal() code a bit. * Renamed $destRel => $dstRel for consistency. Tim Starling's comment: Would it be possible to move setContainerAccess() to cloudfiles after the 1.19 branch point? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
