"Catrope" changed the status of MediaWiki.r110412 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110412#c30346
Old Status: new > New Status: ok Commit summary for MediaWiki.r110412: Remainder of the changes from r109565 - adds net_helpfulness as an actual column, rather than a calculated one, making sorting/fitlering on it less of a problem. Catrope's comment: This looks good in terms of DB load, but I should point out that the continue feature won't work properly if you're sorting by anything other than ID. For instance, imagine you're sorting by helpfulness with limit=10, and there are more than 10 rows with net_helpfulness=3. Your code will either get in an infinite loop of showing the same results over and over again, or skip over a bunch of rows because it continues to the rows with net_helpfulness=4. To make this work, you'd need to sort by, continue by, and index on, the (net_helpfulness, id) tuple. You can find examples in API modules in core MW, or talk to me for help. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
