"Tbleher" changed the status of MediaWiki.r109111 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109111#c30353
Old Status: ok
> New Status: fixme
Commit summary for MediaWiki.r109111:
Refactored SpamBlacklist to be extendable for other blacklist types
This is the groundwork for Bug 33761
Tbleher's comment:
The articleSave() function is missing a return code at the end, leading to the
following error when trying to edit [[MediaWiki:spam-blacklist]]:
<pre>
Detected bug in an extension! Hook SpamBlacklistHooks::articleSave failed to
return a value; should return true to continue hook processing or false to
abort.
Backtrace:
#0 /srv/www/mediawiki/code/includes/GlobalFunctions.php(3799):
Hooks::run('ArticleSaveComp...', Array)
#1 /srv/www/mediawiki/code/includes/WikiPage.php(1448):
wfRunHooks('ArticleSaveComp...', Array)
#2 [internal function]: WikiPage->doEdit(' # Externe URLs...', '', 98)
#3 /srv/www/mediawiki/code/includes/Article.php(1777):
call_user_func_array(Array, Array)
#4 /srv/www/mediawiki/code/includes/EditPage.php(1434):
Article->__call('doEdit', Array)
#5 /srv/www/mediawiki/code/includes/EditPage.php(1434): Article->doEdit(' #
Externe URLs...', '', 98)
#6 /srv/www/mediawiki/code/includes/EditPage.php(959):
EditPage->internalAttemptSave(Array, false)
#7 /srv/www/mediawiki/code/includes/EditPage.php(357): EditPage->attemptSave()
#8 /srv/www/mediawiki/code/includes/actions/EditAction.php(51): EditPage->edit()
#9 /srv/www/mediawiki/code/includes/actions/EditAction.php(71):
EditAction->show()
#10 /srv/www/mediawiki/code/includes/Wiki.php(484): SubmitAction->show()
#11 /srv/www/mediawiki/code/includes/Wiki.php(278):
MediaWiki->performAction(Object(Article))
#12 /srv/www/mediawiki/code/includes/Wiki.php(593): MediaWiki->performRequest()
#13 /srv/www/mediawiki/code/includes/Wiki.php(503): MediaWiki->main()
#14 /srv/www/mediawiki/code/index.php(58): MediaWiki->run()
#15 {main}
</pre>
The following patch fixes the issue for me:
<pre>
--- a/SpamBlacklistHooks.php
+++ b/SpamBlacklistHooks.php
@@ -164,5 +164,6 @@ class SpamBlacklistHooks {
foreach ( BaseBlacklist::getBlacklistTypes() as $type => $class
) {
$wgMemc->delete( "$wgDBname:{$type}_blacklist_regexes"
);
}
+ return true;
}
}
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
