"Aaron Schulz" changed the status of MediaWiki.r109993 to "resolved" and
commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109993#c30407
Old Status: fixme
> New Status: resolved
Commit summary for MediaWiki.r109993:
[Html] Unit test + bugfix Html::namespaceSelector
* Previously it was passing $selectAttribs['name'] to Xml::label, which uses
its value for the <label for=""> attribute. This works as long as
$selectAttribs['id'] and $selectAttribs['name'] match, but when they don't it
fails. <label for=""> always corresponds with <{input,text area,select} id="">
in browsers, never with "name".
* Make name/id match eachother by default to avoid backwards compatibility
breakages (they used to match in the Xml class method as well)
* Add HtmlTest.php entries similar to the ones in XmlTest
* Fix E_NOTICE about $params['selected'], default to ''
-- Follows-up r109974, r109698, r109990
-- Bug originally introduced in r41425
-- XmlTest.php still runs successfully
-- HtmlTest.php runs successfully
Aaron Schulz's comment:
Fixed in r110597.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
