"Catrope" posted a comment on MediaWiki.r110600. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110600#c30410
Commit summary for MediaWiki.r110600: Revert r106007 (Split Gadget modules into two, one for scripts and one for styles): I like the concept of having multiple modules, and I'll probably implement this in the RL2 branch, but this specific implementation has issues (subclassing OutputPage, building its own head items) that were pointed out on CR but never fixed. Catrope's comment: No, those were actually good. I forgot to mention that: loading styles early was actually done right in r100497. The only thing that r106007 changed was that styles were split out into a separate module and no longer loaded twice. Loading styles twice is not the nicest thing ever but I don't think it's a big issue. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
