"Siebrand" changed the status of MediaWiki.r110542 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110542#c30425

Old Status: ok
> New Status: fixme

Commit summary for MediaWiki.r110542:

Enqueue mw.util.init in document-ready even handler earlier
* Previously $(document).ready(mw.util.init) was in module 
'mediawiki.page.ready' (position: bottom). I've now moved this to 
'mediawiki.page.startup' so that it'll be enqueued sooner.
* This making it more likely that if someone also enqueues in document-ready 
that mw.util.init ran before than and thus mw.util.$content populated
* Fixes bug 33711

* All this is still depends on the order in which the event handler queue is 
executed, which is risky. Bug 30713 will bring the solid "watertight" solution

Siebrand's comment:

This killed unit tests. http://integration.mediawiki.org/testswarm/job/1091/

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to