"Krinkle" posted a comment on MediaWiki.r110542.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110542#c30428
Commit summary for MediaWiki.r110542:
Enqueue mw.util.init in document-ready even handler earlier
* Previously $(document).ready(mw.util.init) was in module
'mediawiki.page.ready' (position: bottom). I've now moved this to
'mediawiki.page.startup' so that it'll be enqueued sooner.
* This making it more likely that if someone also enqueues in document-ready
that mw.util.init ran before than and thus mw.util.$content populated
* Fixes bug 33711
* All this is still depends on the order in which the event handler queue is
executed, which is risky. Bug 30713 will bring the solid "watertight" solution
Krinkle's comment:
<blockquote>Followup r110542: unbreak the QUnit tests; the change wasn't broken
but the test runner was. Reflect the dependency change (mw.page.startup now
depends on mw.util) by moving up mw.util . It's kind of annoying that the test
suite doesn't use the dependency map from Resources.php</blockquote>
Aha, spot on. I'm actually using {{blue|Special:JavaScriptTest/qunit}} locally
instead of the old qunit/tests/index.html. We need to get that tested on labs
asap and deployed on live integration server.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
