"Tim Starling" changed the status of MediaWiki.r63018 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/63018#c30442
Old Status: ok > New Status: fixme Commit summary for MediaWiki.r63018: (bug 17560) Half-broken deletion moved image files to deletion archive without updating DB Tim Starling's comment: <pre> + $status = Status::newFatal( 'error' ); </pre> "error" is not an informative error message. Also, it would be nice if the file deletion could proceed even if the article is missing, since this is a plausible state for an image to be in, and presumably deleting it is a reasonable way to clean up such a state. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
