"Aaron Schulz" posted a comment on MediaWiki.r110716.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110716#c30485

Commit summary for MediaWiki.r110716:

Please review carefully, I cannot see negative side effects from this patch. It 
gives extensions which use the (depreacted) UnknownAction hook a chance to see 
the original action= value. This fixes bug 34203 and bug 34161 UnknownAction 
hook problem: the hook must pass the unknown action to the callee and not the 
value "nosuchaction"

Aaron Schulz's comment:

See 
https://svn.wikimedia.org/viewvc/mediawiki/branches/REL1_18/phase3/includes/Wiki.php?revision=107907&view=markup

In 1.18 $act was the result of getAction(), which isn't quite the same as what 
happens here.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to