"Wikinaut" changed the status of MediaWiki.r110716 to "new" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110716#c30490
Old Status: ok > New Status: new Commit summary for MediaWiki.r110716: Please review carefully, I cannot see negative side effects from this patch. It gives extensions which use the (depreacted) UnknownAction hook a chance to see the original action= value. This fixes bug 34203 and bug 34161 UnknownAction hook problem: the hook must pass the unknown action to the callee and not the value "nosuchaction" Wikinaut's comment: I reset my patch "new", because the performance impact of the additional "$request->getVal( 'action', 'view' )" should be discussed; my patch should of course not degrade MW core performance. Can someone say some words (and hopefully take away my concerns regarding mw performance degradation) ? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
