"Catrope" posted a comment on MediaWiki.r110592. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110592#c30593
Commit summary for MediaWiki.r110592: Followup r108184: per CR, blocking loads in debug mode were broken because debug mode uses chained loading, and the second part of the chain would run after the blocking flag had been set back to false. So get rid of the blocking flag as a global state flag, and instead pass it around all over the place so nestedAddScript() can use it. Catrope's comment: Yeah, it's not the cleanest code I ever wrote, but it's needed because the asynchronous nature of things means that an object-wide state variable doesn't cut it. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
