"Khorn (WMF)" posted a comment on Wikimedia.r1158. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1158#c30597
Commit summary for Wikimedia.r1158: Adding Global Collect standalone adapter. Khorn (WMF)'s comment: I realize it's far too late in this particular game to lodge a complaint about the general approach, but the fact that the standalone adapter you have written here has a completely different structure than the DonationInterface globalcollect adapter basically means that at some point in the future, we will have to re-write at least some aspects of both adapters in parallel, essentially having to do the work twice. I had been under the impression that the standalone and the DonationInterface adapters would be interchangable as far as the controlling object was concerned, which would have allowed us to drop in the full DonationInterface adapter library once we had completed the work of incrementally moving those classes into a state that was more or less de-coupled from MediaWiki. Clearly that is no longer an option. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
