"Khorn (WMF)" changed the status of Wikimedia.r1255 to "resolved" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1255#c30606
Old Status: new > New Status: resolved Commit summary for Wikimedia.r1255: Added parseResponse() and xmlChildrenToArray(). Khorn (WMF)'s comment: <pre>* @return array Returns the parsed xml string as an array.</pre> That's not exactly true. It converts one level of xml child nodes into a key=>value array, where the key is the node name and the value is the xml node value, for all children of the speficied node. This is a function you want to use, if and only if the node you specify appears by name in the xml exactly once, and all its children nodes are both unique, and are leaves in the tree (no children of their own). Aside from the documentation, all outstanding issues with this rev seem to have been addressed in later commits. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
