"Catrope" changed the status of MediaWiki.r111013 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111013#c30631
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r111013:
Apply changes per CR r111001: direct comparisons with undefined, Error instead
of $.error, and use mw.util.wikiScript
Catrope's comment:
<pre>
- if ( typeof options.info != 'undefined' ) {
+ if ( options.info === undefined ) {
</pre>
You're inverting the logic there, pretty sure that's wrong.
OK otherwise.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
