"Catrope" posted a comment on MediaWiki.r111014.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111014#c30634

Commit summary for MediaWiki.r111014:

1.19 schema migration script for wmf,
exempts revision.rev_sha1 column from enwiki for now

Catrope's comment:

Per IRC, the root pass should be pulled from /usr/local/bin not from 
/home/wikipedia/bin , because the only the latter is managed by puppet (and 
it's what's actually in $PATH), and the commented-out line of code should be 
removed.

Looks good otherwise.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to