"Aaron Schulz" posted a comment on MediaWiki.r111028. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111028#c30664
Commit summary for MediaWiki.r111028: (bug 34254) fix gzipped file cache double compressing output A gzipped file cache is enabled by setting $wgUseGzip and $wgUseFileCache. To save CPU cycles, HTMLFileCache would print the compressed output as is but WebStart uses an ob_gzhandler so we end up with a double compression. Aaron Schulz's comment: What about pages that cannot be cached? This seems to disable output compression for such cases, which increases network traffic. You only want to disable gzipped buffering when you are going to read or save from the cache. Places that trap output to the cache have calls like <code>ob_start( array( &$cache, 'saveToFileCache' ) );</code>. ob_start() should create a new buffer that is not compressed. FileCacheBase::saveText() will then gzip or not gzip the uncompressed text as needed, so that aspect is OK. Any double-zipping problems will be in FileCacheBase::loadFromFileCache(), as you probably know already. Maybe the code you added in this revision should go there instead. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
