"Tim Starling" changed the status of MediaWiki.r108380 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108380
Old status: new > New status: ok Commit summary for MediaWiki.r108380: [mediawiki.action.history.js] Provide cleaner handling of action=historysubmit hack. * Follows-up r108341, r108370 * Doesn't remove it, server will still handle them properly (as provided by r57415) when JavaScript is off. This commit adds a progressive enhancement when possible so that submit will go to either of these: * title= & diff= & oldid= * action=revisiondelete & ids[..]= instead of one of these * action=historysubmit & title= & diff= & oldid= & ids[..]= * action=historysubmit & revisiondelete=1 & ids[..]= diff= & oldid= (removing redundant parameters and parameters from the other submission-type that don't belong in that url) * Also re-adding support for action= revisiondelete in the query, as it was originally. Due to this hack it appears that support for the original action name (which is still returned as "revisiondelete" from MediaWiki::getAction() ) was removed or never existed in that place of the code at all. Fixed now. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
