"Nikerabbit" changed the status of MediaWiki.r111048 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111048#c30698
Old Status: ok > New Status: fixme Commit summary for MediaWiki.r111048: Fixing some of the "@return true" or "@return false", need to be "@return bool" and then the metadata can say true if foo, false if bar Other documentation improvements Nikerabbit's comment: You are removing information at places. False is explicit failure case and true should never be returned. - * @return ParserOutput|false + * @return ParserOutput|bool _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
