"RobLa-WMF" changed the status of MediaWiki.r111231 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111231#c30773
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r111231:
* Remove last remaining traces of wfLoadExtensionMessages().
* Add missing action message and remove unused global in UploadLocal.
* Some whitespace updates in Maps.
RobLa-WMF's comment:
Per our frequent conversations on wikitech-l, we shouldn't break backwards
compatibility unless we have to. This function is doing no harm (it's doing
nothing). The Semantic MediaWiki folks have explicitly stated their desire to
support older versions of MediaWiki, yet you even broke their code that would
still work *with* removing the function:
<pre>
- if ( version_compare( $wgVersion, '1.16', '<' ) ) {
- wfLoadExtensionMessages( 'SemanticMediaWiki' );
- }
</pre>
...and you removed smwfLoadExtensionMessages() as well.
That's just rude. Please revert.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
