"RobLa-WMF" posted a comment on MediaWiki.r111218. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111218#c30774
Commit summary for MediaWiki.r111218: attempt to fix bug33989 - fix the mode parameter in api call RobLa-WMF's comment: This is so full of win! I love it that such an insidious-seeming bug has a relatively small fix. It might make things a ''little'' easier to understand to call: $wgCategoryTreeCategoryPageOptions['mode'] = CategoryTree::decodeMode( $wgRequest->getVal( 'mode' ) ); ...and then put the $wgCategoryTreeCategoryPageMode setting logic in CategoryTree::decodeMode function, since there's other logic in there which does default setting. That said, on casual inspection it's pretty hard to figure out the interplay of globals here, so I don't think that minor tweak would matter that much. Since this is a tested combination, seems great to call it good for 1.19. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
