"Duplicatebug" posted a comment on MediaWiki.r111185. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111185#c30775
Commit summary for MediaWiki.r111185: (bug 21256) Add "islqttalkpage" parameter to prop=info. Patch is by John Du Hart, with minor style and formatting tweaks by me. Duplicatebug's comment: Please do not add unconditionally new output to a api module. It is better, to add new option to prop=info and check, if the option is set and than add the information. That avoid a waste of performance/time, when the caller does not need that information. With the param you have a documentation at the api help page, which is also a nice to have. You should not create your own title objects (A function you call, need the page id, which is not set in your case and that means a seperate query to the database). Better it is to get the PageSet and operate on the "GoodTitles" (that all pages from the query, which are valid and exist) and maybe on the "MissingTitles" (if you want support this information for non-existing pages). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
