"Siebrand" posted a comment on MediaWiki.r111231. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111231#c30811
Commit summary for MediaWiki.r111231: * Remove last remaining traces of wfLoadExtensionMessages(). * Add missing action message and remove unused global in UploadLocal. * Some whitespace updates in Maps. Siebrand's comment: Hey Rob. Thanks for taking the time to so carefully review the changes I made in this revision. I appreciate it a lot. tl;dr: I think you underestimate the research I did before making these changes. I elaborate below. Reading the README file of SemanticMediaWiki, an extension required by every and all Semantic* extensions, I see that the requirement was MediaWiki 1.16 or later. Any and all checks for lower versions of MediaWiki no longer make sense. smwfLoadExtensionMessages() is a no-op. Calling it does not serve any purpose. It is being kept in SemanticMediaWiki to avoid complete breakage (fatals), and is scheduled to be removed there in SemanticMediaWiki 1.9. GlobalFunctions.php indicated that wfLoadExtensionMessages was marked deprecated in MediaWiki 1.16 some 18 months ago, it has been throwing deprecation warnings since MediaWiki 1.18 and is scheduled to be removed in MediaWiki 1.20. Now that MediaWiki has reached 1.20 alpha state, it is exactly that time to remove it. I don't think the changes made in this revision were rude. No breakage whatsoever was introduced for any MediaWiki version at 1.16 or above. Because of the above, I will not comply to your request to revert. Would you still feel that these changes need to be reverted because they were "just rude" and break backwards compatibility, then feel free to revert yourself, our delegate it to someone else. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
