"Tbleher" posted a comment on MediaWiki.r111168. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111168#c30814
Commit summary for MediaWiki.r111168: GOOD BYE $wgArticle! It was stated that it would be removed in 1.20 and we are in 1.20. Tbleher's comment: At the very least there should be a list of all deprecated global variables, preferably in RELEASE-NOTES. Removed global variables should also be mentioned in the RELEASE-NOTES, as a breaking change. I stumbled across this revision and it really caught me by surprise. I have a few extensions that use $wgArticle, they were written long before $wgArticle was deprecated. How should I have known that $wgArticle was deprecated? If I had not seen this commit by accident, I would probably have searched for a while why my extension didn't work anymore after upgrading to trunk. Calling wfDeprecated sounds like a good idea, but there should also be a list of all deprecations, so it is easier to search for deprecated functions and globals in custom extensions. >From a deloper perspective, I can understand the impulse to remove old, >deprecated code to make the code "cleaner". But please keep in mind that this >makes it much harder to use your work outside of WMF. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
