"Wikinaut" posted a comment on MediaWiki.r111327. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111327#c30874
Commit summary for MediaWiki.r111327: follow-up r111313 . iframes have class= instead of id= . proper use of isset() . Sanitizing the attributes immediately before composing the iframe . rawhtmlencoding the username, so that also spaces arrive as epl usernames. negation of boolean instead of inappropriate negation of string Wikinaut's comment: I think, it looks better. Last open issue: the url. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
