"SPQRobin" posted a comment on MediaWiki.r111017. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111017#c30877
Commit summary for MediaWiki.r111017: put in r110285 again now that 1.19 branched SPQRobin's comment: isKnown was introduced in r44520, with the intention to be a shortcut to both check page existence and to isAlwaysKnown. LinkHolderArray calls isAlwaysKnown and does the page existence check separately so it can do them in batches for pages with a lot of links. Consequently, to ensure consistency, it's best that isKnown remains a "shortcut" exclusively to exists() and isAlwaysKnown. It may be that other functions only call isAlwaysKnown and do their own page existence check. So I would move the hook to isAlwaysKnown, what the docs say is intended for functions calling it, while the hook we want to add is for extra exceptions similar to those in isAlwaysKnown. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
