"Tim Starling" changed the status of MediaWiki.r111264 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111264#c30889
Old Status: new > New Status: fixme Commit summary for MediaWiki.r111264: adding DBDataObject class after having some people review it and posting on the list. docs can currently be found at https://www.mediawiki.org/wiki/User:Jeroen_De_Dauw/DBDataObject Tim Starling's comment: The use of static variables to store database connection objects, and indeed heavy use of static variables generally, is not acceptable. It's basically equivalent to using global variables, except for the syntax. It's the opposite to the direction we are heading with state architecture in MediaWiki. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
